Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLv2] [FE] Migrate _serializeForUrl #37508

Closed
Tracked by #36108
ranquild opened this issue Jan 10, 2024 · 0 comments · Fixed by #37632
Closed
Tracked by #36108

[MLv2] [FE] Migrate _serializeForUrl #37508

ranquild opened this issue Jan 10, 2024 · 0 comments · Fixed by #37632

Comments

@ranquild
Copy link
Contributor

ranquild commented Jan 10, 2024

Blocked by #37659

const query = clean ? this.legacyQuery().clean() : this.legacyQuery();

  • Lib.dropStageIfEmpty(query, -1) is a replacement for clean
  • Lib.toLegacyQuery is a replacement for datasetQuery; i.e. it would serialize the query.

Using of toLegacyQuery caused some inner checks in initializeQB to work differently, that's why this issue is blocked by some changes in somewhat unrelated MLv2 function.

@nemanjaglumac nemanjaglumac self-assigned this Jan 11, 2024
@ranquild ranquild changed the title [MLv2] [FE] Migrate _serializeForUrl [MLv2] [FE] [Blocked] Migrate _serializeForUrl Jan 12, 2024
@kamilmielnik kamilmielnik changed the title [MLv2] [FE] [Blocked] Migrate _serializeForUrl [MLv2] [FE] Migrate _serializeForUrl Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants