Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLv2] [FE] Remove aggregate, breakout, filter methods from Question #37509

Closed
Tracked by #36108
ranquild opened this issue Jan 10, 2024 · 0 comments · Fixed by #37574
Closed
Tracked by #36108

[MLv2] [FE] Remove aggregate, breakout, filter methods from Question #37509

ranquild opened this issue Jan 10, 2024 · 0 comments · Fixed by #37574

Comments

@ranquild
Copy link
Contributor

ranquild commented Jan 10, 2024

There should be no Question-level functions like this. Migrate places that use them to use the legacy StructuredQuery and remove these functions from the Question class.

Before:

const newQuestion = question.aggregate(["count"]);

After:

const newQuestion = question
  .legacyQuery({ useStructuredQuery: true })
  .aggregate(["count"])
  .question();
;
@ranquild ranquild changed the title [MLv2] [FE] Remove aggregate, breakout, filter from Question [MLv2] [FE] Remove aggregate, breakout, filter methods from Question Jan 10, 2024
@kamilmielnik kamilmielnik self-assigned this Jan 11, 2024
@kamilmielnik kamilmielnik added this to the 0.49 milestone Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants