Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLv2] [FE] PinnedQuestionLoader - data permission check #37513

Closed
Tracked by #36108
ranquild opened this issue Jan 10, 2024 · 0 comments · Fixed by #37595
Closed
Tracked by #36108

[MLv2] [FE] PinnedQuestionLoader - data permission check #37513

ranquild opened this issue Jan 10, 2024 · 0 comments · Fixed by #37595

Comments

@ranquild
Copy link
Contributor

ranquild commented Jan 10, 2024

if (loading !== false || !loadedQuestion.legacyQuery()) {

It uses legacyQuery to check for if the user permissions to run the query (if not, dataset_query would be null). Find another way to do it, e.g. add a method to Question class that would check for datasetQuery directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant