Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLv2] [BE] Migrate getColumnKey to MLv2 #37678

Closed
Tracked by #36108
ranquild opened this issue Jan 14, 2024 · 1 comment
Closed
Tracked by #36108

[MLv2] [BE] Migrate getColumnKey to MLv2 #37678

ranquild opened this issue Jan 14, 2024 · 1 comment
Labels
.Backend .metabase-lib Label for tracking all issues related to the shared CLJC metabase-lib .Team/QueryProcessor :hammer_and_wrench:

Comments

@ranquild
Copy link
Contributor

ranquild commented Jan 14, 2024

Blocks #37687

This is the primary function for computing keys for viz settings. It should be fully ported to clojure, so the FE won't have to know so much details about field references format. I'd add this function to a new top-level file in metabase-lib, e.g. visualizations etc. to make it clear it's viz-specific.

Possible signature:

getVizColumnKey(column: DatasetColumn): string;

In context of viz query isn't available, so it would be great to make it work with the column only.

@ranquild ranquild closed this as not planned Won't fix, can't repro, duplicate, stale Jan 14, 2024
@ranquild ranquild reopened this Jan 15, 2024
@ranquild ranquild changed the title [MLv2] [FE] getColumnKey [MLv2] [BE] Migrate getColumnKey to MLv2 Jan 15, 2024
@kamilmielnik kamilmielnik added .Backend .metabase-lib Label for tracking all issues related to the shared CLJC metabase-lib .Team/QueryProcessor :hammer_and_wrench: labels Jan 18, 2024
@metamben
Copy link
Contributor

metamben commented Feb 6, 2024

Marking this as blocked, because we need a decision if it this is really needed in the form proposed here. @ranquild might be able to say what exactly is needed.

@ranquild ranquild closed this as not planned Won't fix, can't repro, duplicate, stale Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Backend .metabase-lib Label for tracking all issues related to the shared CLJC metabase-lib .Team/QueryProcessor :hammer_and_wrench:
Projects
None yet
Development

No branches or pull requests

3 participants