Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MLv2] [BE] Incorrect isTemporalExtraction value #38253

Closed
Tracked by #36108
kamilmielnik opened this issue Jan 30, 2024 · 0 comments · Fixed by #38358
Closed
Tracked by #36108

[MLv2] [BE] Incorrect isTemporalExtraction value #38253

kamilmielnik opened this issue Jan 30, 2024 · 0 comments · Fixed by #38358
Assignees
@metamben
Labels
.Backend .metabase-lib Label for tracking all issues related to the shared CLJC metabase-lib .Team/QueryProcessor :hammer_and_wrench: Type:Bug Product defects

Comments

@kamilmielnik
Copy link
Contributor

kamilmielnik commented Jan 30, 2024 •
edited

Blocks #37172

To reproduce

  1. git checkout 37172-set-default-display ([MLv2] [FE] Migrate setDefaultDisplay to MLv2 #38221)
  2. Run any of the following 4 e2e tests:
    • e2e/test/scenarios/binning/qb-explicit-joins.cy.spec.js:
      • via simple mode -> should work for time series
      • via notebook mode -> should work for time series
    • e2e/test/scenarios/binning/sql.cy.spec.js
      • via simple question -> should work for time series
      • via custom question -> should work for time series

In all these cases info.isTemporalExtraction is true but it should be false. This causes the tests to fail.

Temporal extraction occurs when using "extraction units", see image.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metamben metamben

Labels
.Backend .metabase-lib Label for tracking all issues related to the shared CLJC metabase-lib .Team/QueryProcessor :hammer_and_wrench: Type:Bug Product defects
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent categorizing extraction of/truncation to year as temporal-extraction metabase/metabase
2 participants
@kamilmielnik @metamben