Cannot import dashboards with circular click behavior

[zbodi74]

Describe the bug

It is impossible to import dashboards with a circular click behavior, for example, when a dashboard links to itself, or when click behavior dashboard A has a link pointing to dashboard B which has a link pointing to dashboard A.

To Reproduce

1. Create a DashboardA, add a QuestionA
2. Create DashboardB, add a QuestionB
3. Set up a circular click route between the dashboards:
   • DashboardA/QuestionA --> DashboardB
   • DashboardB/QuestionB --> DashboardA
4. Export everything
5. (!) Import and see the circular reference error below

Expected behavior

The import should work, load all resources, and restore all exported links.

Logs

clojure.lang.ExceptionInfo: Circular dependency on [{:model "Dashboard", :id "GUnezeAXjrWMd8k4x8PXx"}] {:path [{:model "Dashboard", :id "GUnezeAXjrWMd8k4x8PXx"}]}

Information about your Metabase installation

Reported in v47, also broken as of 1.48.5.

Severity

Reported by a customer. No workaround, apart from removing some of the links..

Additional context

No response

[bshepherdson]

Ah, someone found it! I wondered if there was a cycle opportunity anywhere in our data model, and here's one after all.

[michael-stott]

Good spot. I just came looking for this. It looks like I just hit the same thing using 1.49.3. Or should I say it looks very much the same. Our 'Home' dashboard has links to various other dashboards and then each of those have a link back to the 'Home'.

[andreasenberg]

I'm experiencing something that looks a lot like this on 1.49.5 when using link cards to handle navigation back and forth between dashboards. I'm not sure if they are represented in a similar way as a linked question in the exported yaml files so that a fix for the issue described here potentially also would resolve the issue I'm facing?

Regardless, it would be great if the link card issue could be included as a scenario to adress/test together with changes intended to fix this. Let me know if you rather have these issues separated into two github issues and I'll create one for my scenario.