Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dc.js migration] axis labels and names on timeseries and numeric charts are not highlightable #38915

Open
Tracked by #37306
EmmadUsmani opened this issue Feb 19, 2024 · 4 comments
Open
Tracked by #37306

[dc.js migration] axis labels and names on timeseries and numeric charts are not highlightable #38915

EmmadUsmani opened this issue Feb 19, 2024 · 4 comments
Labels
.echarts-regression Issues in the echarts feature branch that were not broken in the previous dc.js implementation .echarts-scope Issues related to chart types that have already been or will be migrated to echarts. Priority:P3 Cosmetic bugs, minor bugs with a clear workaround .Team/DashViz Dashboard and Viz team Type:Bug Product defects

Comments

@EmmadUsmani
Copy link
Contributor

EmmadUsmani commented Feb 19, 2024 •
edited

Screenshot 2024-02-19 at 8 31 22 AM

Before we used to be able to highlight all text on the chart (axes ticks, labels, data labels, legend)

Now in the echarts implementation we can only highlight the legend
@EmmadUsmani EmmadUsmani mentioned this issue Feb 19, 2024
Open
@EmmadUsmani EmmadUsmani added .echarts-regression Issues in the echarts feature branch that were not broken in the previous dc.js implementation .echarts-scope Issues related to chart types that have already been or will be migrated to echarts. Priority:P3 Cosmetic bugs, minor bugs with a clear workaround labels Feb 19, 2024
@EmmadUsmani
Copy link
Contributor Author

apache/echarts#13585

Solution is to manually add the user-select style to the root svg element

@EmmadUsmani
Copy link
Contributor Author

I tried implementing that solution but for some reason left click is not working. I can select text with right click, but cannot left click.

@alxnddr
Copy link
Member

alxnddr commented Mar 11, 2024

Does not seem important to spend time on

@alxnddr alxnddr closed this as completed Mar 11, 2024
@EmmadUsmani EmmadUsmani closed this as not planned Won't fix, can't repro, duplicate, stale Mar 11, 2024
@alxnddr alxnddr reopened this Mar 11, 2024
@kulyk kulyk assigned kulyk and unassigned kulyk Mar 19, 2024
@kulyk
Copy link
Member

kulyk commented Mar 19, 2024

Setting this aside for now — tried hacking something together with user-select and/or pointer-events, but no luck :(

@EmmadUsmani EmmadUsmani added Priority:P2 Average run of the mill bug and removed Priority:P3 Cosmetic bugs, minor bugs with a clear workaround labels Mar 25, 2024
@alxnddr alxnddr self-assigned this Apr 1, 2024
@alxnddr alxnddr mentioned this issue Apr 2, 2024
Merged
@alxnddr alxnddr changed the title [dc.js migration] text on chart is not highlightable [dc.js migration] axis labels and names on timeseries and numeric charts are not highlightable Apr 3, 2024
@alxnddr alxnddr added Priority:P3 Cosmetic bugs, minor bugs with a clear workaround and removed Priority:P2 Average run of the mill bug labels Apr 3, 2024
@cdeweyx cdeweyx added Type:Bug Product defects .Team/DashViz Dashboard and Viz team labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
.echarts-regression Issues in the echarts feature branch that were not broken in the previous dc.js implementation .echarts-scope Issues related to chart types that have already been or will be migrated to echarts. Priority:P3 Cosmetic bugs, minor bugs with a clear workaround .Team/DashViz Dashboard and Viz team Type:Bug Product defects
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@alxnddr @cdeweyx @kulyk @JesseSDevaney @EmmadUsmani