Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wide logos cover the icon to collapse the sidebar #40153

Closed
paoliniluis opened this issue Mar 14, 2024 · 0 comments · Fixed by #40386
Closed

Wide logos cover the icon to collapse the sidebar #40153

paoliniluis opened this issue Mar 14, 2024 · 0 comments · Fixed by #40386
Assignees
@rafpaf
Labels
.Escalation .Frontend Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Team/AdminWebapp Admin and Webapp team Type:Bug Product defects
Milestone
0.49.1

Comments

@paoliniluis
Copy link
Contributor

paoliniluis commented Mar 14, 2024 •
edited
Loading

Describe the bug

When using custom logos, if your logo is too big it will cover the icon to collapse the sidebar

To Reproduce

  1. add this logo
    images (2)
  2. see how it looks

Expected behavior

We shouldn't cover the logo

Logs

No response

Information about your Metabase installation

v49

Severity

P2

Additional context

P2 as you're forced to wipe the logo
@paoliniluis paoliniluis added Type:Bug Product defects Priority:P2 Average run of the mill bug .Frontend .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. labels Mar 14, 2024
@paoliniluis paoliniluis mentioned this issue Mar 20, 2024
Closed
@iethree iethree added the .Team/AdminWebapp Admin and Webapp team label Mar 20, 2024
@rafpaf rafpaf mentioned this issue Mar 20, 2024
Merged
1 task
@WiNloSt WiNloSt added this to the 0.49.1 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafpaf rafpaf

Labels
.Escalation .Frontend Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Team/AdminWebapp Admin and Webapp team Type:Bug Product defects
Projects
None yet
Milestone
0.49.1
Development

Successfully merging a pull request may close this issue.

Accommodate wide icons in nav and admin nav metabase/metabase
5 participants
@rafpaf @paoliniluis @WiNloSt @cbalusek @iethree