Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter filter widget jumps and doesn't allow to pick a value #40232

Closed
oleggromov opened this issue Mar 18, 2024 · 2 comments · Fixed by #40378
Closed

Parameter filter widget jumps and doesn't allow to pick a value #40232

oleggromov opened this issue Mar 18, 2024 · 2 comments · Fixed by #40378
Assignees
Labels
.Frontend Priority:P2 Average run of the mill bug Querying/Native The SQL/native query editor Querying/Parameters & Variables Filter widgets, field filters, variables etc. Type:Bug Product defects
Milestone

Comments

@oleggromov
Copy link
Contributor

oleggromov commented Mar 18, 2024

Describe the bug

Instead of allowing to pick the value for the filter, the widget jumps (as if sorting has begun) and does nothing.

Screen.Recording.2024-03-18.at.12.41.47.mov

Must be related to Sortable because when I comment it out, the bug no longer exists. https://github.com/metabase/metabase/blob/master/frontend/src/metabase/parameters/components/ParametersList.jsx#L53-L59

To Reproduce

  1. Create a native query with a template tag. Literlaly {{ x }} will work
  2. Set it to a list of values (shouldn't contain actual values)
  3. Try clicking the filter widget, entering a value and clicking "add" or "update"

May not be 100% reproducible every time but at some point you'll see awkward jumping and the actual adding/change won't happen.

Expected behavior

The value should be selectable.
It shouldn't "jump" without actual dragging happening.

Logs

No response

Information about your Metabase installation

True as of `6fe41dd4379f4476b3eb78215b600393dd34474d`

Severity

P3

Additional context

No response

@npfitz npfitz self-assigned this Mar 18, 2024
@paoliniluis paoliniluis added Priority:P2 Average run of the mill bug Querying/Parameters & Variables Filter widgets, field filters, variables etc. Querying/Native The SQL/native query editor .Frontend and removed .Needs Triage labels Mar 19, 2024
@brianschillaci
Copy link

I'm getting this exact same issue in my instance. I just upgraded to version v0.49.0

@urkle
Copy link

urkle commented Mar 20, 2024

The issue seems to be that the popup filter chooser is draggable and drags the field to a different order.

e.g. I have a question with 2 date filters and I try to "select" the date text and instead it MOVES the filter to a different position instead of selecting the text. and clicking + dragging anywhere on the popup drags the field instead.

This is a new issues in 0.49.0 (did not exist in 0.48.9 or lower)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Frontend Priority:P2 Average run of the mill bug Querying/Native The SQL/native query editor Querying/Parameters & Variables Filter widgets, field filters, variables etc. Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants