Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comprehensive tests for CSV Replacement #40368

Closed
Tracked by #38788
crisptrutski opened this issue Mar 20, 2024 · 1 comment · Fixed by #40899
Closed
Tracked by #38788

Comprehensive tests for CSV Replacement #40368

crisptrutski opened this issue Mar 20, 2024 · 1 comment · Fixed by #40899
Assignees
@crisptrutski
Labels
.Team/BackendComponents also known as BEC

Comments

@crisptrutski
Copy link
Contributor

crisptrutski commented Mar 20, 2024 •
edited
Loading

For Appends the end-to-end testing is pretty thin. We've matched it, but maybe we want more?

As far as component-level Integration tests, there a lot to do.

We should match and even improve on the Append coverage at least.
@crisptrutski crisptrutski mentioned this issue Mar 20, 2024
Closed
@crisptrutski crisptrutski self-assigned this Mar 20, 2024
@crisptrutski crisptrutski added the .Team/BackendComponents also known as BEC label Mar 20, 2024
@crisptrutski crisptrutski changed the title Write API level tests for CSV Replacement API tests for CSV Replacement Mar 20, 2024
@crisptrutski crisptrutski mentioned this issue Mar 20, 2024
Merged
4 tasks
@crisptrutski
Copy link
Contributor Author

crisptrutski commented Mar 25, 2024 •
edited
Loading

We should also add some e2e tests. We might as well cover TSVs at the same time.

We have e2e coverage for both of these now.

@crisptrutski crisptrutski changed the title API tests for CSV Replacement Acceptance tests for CSV Replacement Mar 25, 2024
@crisptrutski crisptrutski changed the title Acceptance tests for CSV Replacement Comprehensive tests for CSV Replacement Apr 2, 2024
@crisptrutski crisptrutski mentioned this issue Apr 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crisptrutski crisptrutski

Labels
.Team/BackendComponents also known as BEC
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Testing parity for appending to and replacing uploads metabase/metabase
1 participant
@crisptrutski