Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iframe embedding overflow widgets issue #40660

Closed
bitshadow opened this issue Mar 27, 2024 · 0 comments · Fixed by #40841
Closed

Iframe embedding overflow widgets issue #40660

bitshadow opened this issue Mar 27, 2024 · 0 comments · Fixed by #40841
Assignees
Labels
Embedding/ Use this label when unsure which flavor of embedding is impacted .Frontend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Type:Bug Product defects
Milestone

Comments

@bitshadow
Copy link

bitshadow commented Mar 27, 2024

Describe the bug

Screenshot 2024-03-27 at 10 50 14 AM

EmbedFrame is not resizing according to the widgets inside it. Widgets are overflowing out side of the main container.
Setting overflow: 'auto' from dev tools fixes the issue however we can't inject the styles in iframe.

To Reproduce

  1. Create a dashboard with lots of widgets
  2. Render the iframe with Light theme inside the parent app with black background.
  3. You will see frame container is falling short of the combined widgets height.

Expected behavior

Background container should expand to the full widgets height.

Logs

No response

Information about your Metabase installation

{
  "browser-info": {
    "language": "en-GB",
    "platform": "MacIntel",
    "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/123.0.0.0 Safari/537.36",
    "vendor": "Google Inc."
  },
  "system-info": {
    "file.encoding": "UTF-8",
    "java.runtime.name": "OpenJDK Runtime Environment",
    "java.runtime.version": "11.0.22+7",
    "java.vendor": "Eclipse Adoptium",
    "java.vendor.url": "https://adoptium.net/",
    "java.version": "11.0.22",
    "java.vm.name": "OpenJDK 64-Bit Server VM",
    "java.vm.version": "11.0.22+7",
    "os.name": "Linux",
    "os.version": "4.14.336-253.554.amzn2.x86_64",
    "user.language": "en",
    "user.timezone": "GMT"
  },
  "metabase-info": {
    "databases": [
      "postgres",
      "redshift",
      "h2"
    ],
    "hosting-env": "unknown",
    "application-database": "postgres",
    "application-database-details": {
      "database": {
        "name": "PostgreSQL",
        "version": "12.17"
      },
      "jdbc-driver": {
        "name": "PostgreSQL JDBC Driver",
        "version": "42.6.0"
      }
    },
    "run-mode": "prod",
    "version": {
      "date": "2024-02-12",
      "tag": "v1.48.6",
      "hash": "b8818f9"
    },
    "settings": {
      "report-timezone": "UTC"
    }
  }
}

Severity

blocking your usage of metabase entierly

Additional context

No response

@ranquild ranquild added Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Embedding/ Use this label when unsure which flavor of embedding is impacted .Frontend and removed .Needs Triage labels Mar 27, 2024
@WiNloSt WiNloSt self-assigned this Mar 27, 2024
@WiNloSt WiNloSt mentioned this issue Apr 1, 2024
1 task
@WiNloSt WiNloSt added this to the 0.49.4 milestone Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Embedding/ Use this label when unsure which flavor of embedding is impacted .Frontend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants