Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public dashboards no longer allow titled=false in url parameters (only allows true) #40815

Closed
bharlettvista opened this issue Mar 29, 2024 · 3 comments
Assignees
Labels
.Frontend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/MBQL Type:Bug Product defects
Milestone

Comments

@bharlettvista
Copy link

Describe the bug

example:
https://metabase.company.com/public/dashboard/32c37b38-318a-4321-b142-99098kii89#theme=transparent&bordered=false&titled=false <- will load the page but the data will never populate, just spinning loader for every widget.

https://metabase.company.com/public/dashboard/32c37b38-318a-4321-b142-99098kii89#theme=transparent&bordered=false&titled=true <- everything loads just as it should except now has ugly title on the page.

this is happening directly after upgrading to v0.49.2 from v0.49.1

this seems to only apply to the title parameter, all the other params seem to still works as normal.

example:
#theme=transparent&bordered=false&titled=false <- FAILS
#theme=transparent&bordered=false&titled=true <- WORKS
#theme=transparent&bordered=false <-WORKS
#theme=transparent&bordered=true <- WORKS
#titled=false <-FAILS
#titled=true <- WORKS

To Reproduce

happens when sharing any dashboard and attempting to hide the title of the dashboard by embedding via simple iframe or directly accessing the shared url with the parameters set as follows:
#theme=transparent&bordered=false&titled=false

Expected behavior

No response

Logs

No response

Information about your Metabase installation

{
  "browser-info": {
    "language": "en-US",
    "platform": "MacIntel",
    "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/122.0.0.0 Safari/537.36",
    "vendor": "Google Inc."
  },
  "system-info": {
    "file.encoding": "UTF-8",
    "java.runtime.name": "OpenJDK Runtime Environment",
    "java.runtime.version": "11.0.22+7-post-Ubuntu-0ubuntu222.04.1",
    "java.vendor": "Ubuntu",
    "java.vendor.url": "https://ubuntu.com/",
    "java.version": "11.0.22",
    "java.vm.name": "OpenJDK 64-Bit Server VM",
    "java.vm.version": "11.0.22+7-post-Ubuntu-0ubuntu222.04.1",
    "os.name": "Linux",
    "os.version": "5.15.0-92-generic",
    "user.language": "en",
    "user.timezone": "America/Detroit"
  },
  "metabase-info": {
    "databases": [
      "mysql"
    ],
    "hosting-env": "unknown",
    "application-database": "mysql",
    "application-database-details": {
      "database": {
        "name": "MariaDB",
        "version": "10.11.6-MariaDB-1:10.11.6+maria~ubu2204"
      },
      "jdbc-driver": {
        "name": "MariaDB Connector/J",
        "version": "2.7.10"
      }
    },
    "run-mode": "prod",
    "version": {
      "date": "2024-03-21",
      "tag": "v0.49.1",
      "hash": "54ef5e9"
    },
    "settings": {
      "report-timezone": null
    }
  }
}

Severity

High / Breaking

Additional context

No response

@ranquild ranquild added Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Embedding/ Use this label when unsure which flavor of embedding is impacted .Frontend and removed .Needs Triage labels Mar 29, 2024
@deniskaber deniskaber self-assigned this Mar 29, 2024
@deniskaber
Copy link
Contributor

Hello @bharlettvista !

Thank you for reporting the issue.
I tried to reproduce this issue in different ways, but didn't manage to achieve results - dashboard loads without any errors even if I pass titled=false.

Could you please double-check the full list of URL parameters you pass to a dashboard and send them to us. Also, could you please check if any console errors happen if you would pass titled=false ?

Thank you!

@bharlettvista
Copy link
Author

bharlettvista commented Mar 29, 2024

Hi!,

the only parameters we are passing are: #theme=transparent&bordered=false&titled=false
when titled=false is passed, the widgets are loaded but there is no data just the loading spinner forever

its strange, when we pass the titled=false param there are no console errors, but also there are less 'files' pulled in via the (chrome dev console) Networking page....

example Networking tab when titled=false:
Screenshot 2024-03-29 at 12 52 24 PM

example Netwokring tab when titled is not passed in the URL, and all the data loads properly:
Screenshot 2024-03-29 at 12 53 39 PM

@deniskaber deniskaber added Querying/MBQL and removed Embedding/ Use this label when unsure which flavor of embedding is impacted labels Mar 29, 2024
@ranquild ranquild assigned ranquild and unassigned deniskaber Apr 1, 2024
@ranquild ranquild added this to the 0.49.3 milestone Apr 1, 2024
@ranquild
Copy link
Contributor

ranquild commented Apr 1, 2024

Fixed by #40836

@ranquild ranquild closed this as completed Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Frontend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/MBQL Type:Bug Product defects
Projects
None yet
Development

No branches or pull requests

3 participants