Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"No method in multimethod 'coerce-temporal' for dispatch value: [nil java.time.LocalDateTime]" when evaluating null datetimes #40885

Closed
paoliniluis opened this issue Apr 2, 2024 · 0 comments · Fixed by #40957
Closed

"No method in multimethod 'coerce-temporal' for dispatch value: [nil java.time.LocalDateTime]" when evaluating null datetimes #40885

paoliniluis opened this issue Apr 2, 2024 · 0 comments · Fixed by #40957
Assignees
@lbrdnk
Labels
Database/SQLServer .Escalation Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/Notebook/Custom Column Querying/Processor .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Type:Bug Product defects
Milestone
0.49.4

Comments

@paoliniluis
Copy link
Contributor

Describe the bug

Seems that we don't like to evaluate null timestamps in sql server

To Reproduce

  1. spin up a sql server with the sample dataset, then set to null a few rows from the orders table
  2. in metabase: new-> question-> orders table -> custom column: case(isempty([Created At]), 1, 0)
  3. click on the sql button, you'll see the error in the title

Expected behavior

We should be able to compile that

Logs

NA

Information about your Metabase installation

a customer told is this is a regression in v49

Severity

P1

Additional context

wondering how much #40883 has to do on this
@paoliniluis paoliniluis added Type:Bug Product defects Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Database/SQLServer .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Escalation Querying/Notebook/Custom Column Querying/Processor labels Apr 2, 2024
@lbrdnk lbrdnk self-assigned this Apr 2, 2024
@lbrdnk lbrdnk mentioned this issue Apr 3, 2024
Merged
1 task
@lbrdnk lbrdnk added this to the 0.49.4 milestone Apr 3, 2024
@paoliniluis paoliniluis mentioned this issue Apr 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbrdnk lbrdnk

Labels
Database/SQLServer .Escalation Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/Notebook/Custom Column Querying/Processor .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Type:Bug Product defects
Projects
None yet
Milestone
0.49.4
Development

Successfully merging a pull request may close this issue.

Enable not emptyable arguments for is-empty and not-empty clauses metabase/metabase
2 participants
@paoliniluis @lbrdnk