Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not require onConfirm prop in EntityPickerModal #41172

Closed
Tracked by #40717
kamilmielnik opened this issue Apr 9, 2024 · 1 comment · Fixed by #42317
Closed
Tracked by #40717

Do not require onConfirm prop in EntityPickerModal #41172

kamilmielnik opened this issue Apr 9, 2024 · 1 comment · Fixed by #42317
Assignees
@kamilmielnik
Labels
.Frontend .Team/QueryingComponents

Comments

@kamilmielnik
Copy link
Contributor

kamilmielnik commented Apr 9, 2024 •
edited
Loading

See discussion https://github.com/metabase/metabase/pull/40509/files#r1556931796
@kamilmielnik kamilmielnik mentioned this issue Apr 9, 2024
Closed
@kamilmielnik kamilmielnik changed the title Do not require onConfirm prop in EntityPickerModal Do not require onConfirm prop in EntityPickerModal Apr 9, 2024
@kamilmielnik kamilmielnik mentioned this issue Apr 9, 2024
Merged
@kamilmielnik kamilmielnik added .Frontend .Team/QueryingComponents 🧹 no-brainer cleanup issues to clear out when you have an hour left until EoD or something and removed 🧹 no-brainer cleanup issues to clear out when you have an hour left until EoD or something labels Apr 9, 2024
@kamilmielnik kamilmielnik self-assigned this May 7, 2024
@kamilmielnik kamilmielnik mentioned this issue May 7, 2024
Merged
@kamilmielnik
Copy link
Contributor Author

Closed by #42317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kamilmielnik kamilmielnik

Labels
.Frontend .Team/QueryingComponents
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not require onConfirm prop in EntityPickerModal metabase/metabase
1 participant
@kamilmielnik