Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signed Embedding without Title will remove all the tabs of a dashboard as well #41195

Closed
Tony-metabase opened this issue Apr 9, 2024 · 0 comments · Fixed by #41204
Closed

Signed Embedding without Title will remove all the tabs of a dashboard as well #41195

Tony-metabase opened this issue Apr 9, 2024 · 0 comments · Fixed by #41204
Assignees
@deniskaber
Labels
Embedding/Static Static embedding, previously known as signed embedding .Escalation .Frontend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Type:Bug Product defects
Milestone
0.49.4

Comments

@Tony-metabase
Copy link
Contributor

Describe the bug

Removing the Title From a Dashboard will remove all the tabs leaving only the first one

To Reproduce

  1. Go to New Dashboard -> Add 2 tabs -> Add something in the Tabs and embed it using signed embedding and you will get this:
image
  1. Change the parameter to remove the title http://localhost:3000/embed/dashboard/...?tab=21-tab-1#theme=light&bordered&titled=false and the tabs gets removed as well
image

The workaround is to add the Title back but it will break already created dashboards that remove the title

Expected behavior

All Tabs stay there and only the Title gets removed

Logs

None that are relevant

Information about your Metabase installation

Abel to replicate on 49.3 and master

Severity

It will break current implementation so it's blocking

Additional context

No response
@Tony-metabase Tony-metabase added Type:Bug Product defects Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness .Frontend Embedding/Static Static embedding, previously known as signed embedding .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Escalation labels Apr 9, 2024
@deniskaber deniskaber mentioned this issue Apr 9, 2024
Merged
1 task
@darksciencebase darksciencebase added this to the 0.49.4 milestone Apr 10, 2024
@maxdestors maxdestors mentioned this issue Apr 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deniskaber deniskaber

Labels
Embedding/Static Static embedding, previously known as signed embedding .Escalation .Frontend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Type:Bug Product defects
Projects
None yet
Milestone
0.49.4
Development

Successfully merging a pull request may close this issue.

Restore tabs display for embedded dashboard without title metabase/metabase
3 participants
@deniskaber @Tony-metabase @darksciencebase