Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions should render without a fixed-height flexbox parent in React embedding #42199

Closed
Tracked by #41947
heypoom opened this issue May 3, 2024 · 0 comments · Fixed by #42212
Closed
Tracked by #41947

Questions should render without a fixed-height flexbox parent in React embedding #42199

heypoom opened this issue May 3, 2024 · 0 comments · Fixed by #42212
Assignees

Comments

@heypoom
Copy link
Contributor

heypoom commented May 3, 2024

The question component do not have a height by default, so the charts doesn't show up when a SDK user adds it to their page. There is also no style props to pass in height.

The component also doesn't follow the parent container's height / min-height by default, so either the parent must be a flexbox, or the user needs to add a CSS like parent > div { height: 100% } for it to work.

We should be able to render a sane height by default and allow customizing the height. It should also be able to follow the parent component's height without using CSS workarounds.

@heypoom heypoom self-assigned this May 3, 2024
@heypoom heypoom changed the title Questions should render in React embedding without reserving height and using CSS workarounds Questions should render in React embedding without parent height and using CSS workarounds May 3, 2024
@heypoom heypoom changed the title Questions should render in React embedding without parent height and using CSS workarounds Questions should render without a fixed-height flexbox parent in React embedding May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant