Hide creation buttons on search and recents tabs #42977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iethree
added
the
backport
|
mazameli
approved these changes
May 21, 2024
iethree
commented
May 21, 2024
Comment on lines
+101
to
+103
| const [showActionButtons, setShowActionButtons] = useState<boolean>( | ||
| !!actionButtons.length, | ||
| ); |
There was a problem hiding this comment.
another colorable argument for entitypicker context 🤔
There was a problem hiding this comment.
Yeah, I don't love it, but without lifting the tabs state out of tabs view, I'm not sure how else you make it work
iethree
commented
May 21, 2024
There was a problem hiding this comment.
there's only two new tests in this file (testing the action button visibility), but the diff is all messy because i grouped the search tests together in their own block
iethree
commented
May 21, 2024
| @@ -294,7 +321,6 @@ describe("EntityPickerModal", () => { | |||
| recentItems, | |||
| defaultToRecentTab: false, | |||
| initialValue: { model: "card" }, | |||
| onConfirm: jest.fn(), | |||
There was a problem hiding this comment.
i set a default for this prop so we could delete all these redundant props in each test
npfitz
approved these changes
May 24, 2024
Comment on lines
+101
to
+103
| const [showActionButtons, setShowActionButtons] = useState<boolean>( | ||
| !!actionButtons.length, | ||
| ); |
There was a problem hiding this comment.
Yeah, I don't love it, but without lifting the tabs state out of tabs view, I'm not sure how else you make it work
github-actions bot
pushed a commit
that referenced
this pull request
May 24, 2024
* hide creation buttons on search and recents tabs * update e2e tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42976
Description
The "Create a dashboard" and "Create a collection" buttons were pretty confusing on the recents and search screens (they would create items in the root collection), this hides those buttons on the recents and search tabs.
Checklist