Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing plan] Time-over-time comparison #43073

Closed
Tracked by #43006
kamilmielnik opened this issue May 23, 2024 · 0 comments · Fixed by #43724
Closed
Tracked by #43006

[Testing plan] Time-over-time comparison #43073

kamilmielnik opened this issue May 23, 2024 · 0 comments · Fixed by #43724

Comments

@kamilmielnik
Copy link
Contributor

kamilmielnik commented May 23, 2024

Testing plan for https://www.notion.so/metabase/Time-over-time-comparison-UI-for-aggregated-columns-032bb9b47d124731baa9c3c7f954727f

Unit tests

  • For each of offsetClause, diffOffsetClause, percentDiffOffsetClause helpers:
    • returns correct expression clause
    • sets correct name
      • singular offset (=-1)
        • no breakout
        • breakout on binned datetime column
        • breakout on non-binned datetime column
        • breakout on non-datetime column
      • plural offset (<-1)
        • no breakout
        • breakout on binned datetime column
        • breakout on non-binned datetime column
        • breakout on non-datetime column
  • AggregationPicker
    • does not display the option if there are no aggregations
    • correct label
      • single aggregation
      • multiple aggregations
    • calls onAdd when submitted
    • does not call onSelect when submitted
  • CompareAggregations
    • period input
      • does not allow negative values
      • does not allow non-integer values
    • 1 aggregation
      • does not display extra step
      • cannot go back to extra step
    • multiple aggregations
      • displays extra step
      • can go back to extra step
    • submit button is disabled when no columns are selected
    • submit button is disabled when offset value is empty
    • calls onSubmit
      • 1 column
      • multiple columns

e2e tests

  • Via aggregation picker in notebook editor
    • is not displayed when there is no aggregation
    • correct label
      • 1 aggregation
        • no breakout
        • breakout on binned datetime column
        • breakout on non-binned datetime column
        • breakout on non-datetime column
      • multiple aggregations
        • no breakout
        • breakout on binned datetime column
        • breakout on non-binned datetime column
        • breakout on non-datetime column
    • adds new column(s)
      • assert analytic event dispatched
      • assert column name
      • assert valid expression in the notebook editor widget
  • Via aggregation picker in chill mode (summarize)
    • is not displayed when there is no aggregation
    • correct label
      • 1 aggregation
        • no breakout
        • breakout on binned datetime column
        • breakout on non-binned datetime column
        • breakout on non-datetime column
      • multiple aggregations
        • no breakout
        • breakout on binned datetime column
        • breakout on non-binned datetime column
        • breakout on non-datetime column
    • adds new column(s)
      • assert analytic event dispatched
      • assert column name
      • assert valid expression in the notebook editor widget
  • Via plus button in table visualization
    • is not displayed when there is no aggregation
    • correct label
      • 1 aggregation
        • no breakout
        • breakout on binned datetime column
        • breakout on non-binned datetime column
        • breakout on non-datetime column
      • multiple aggregations
        • no breakout
        • breakout on binned datetime column
        • breakout on non-binned datetime column
        • breakout on non-datetime column
    • adds new column(s)
      • assert analytic event dispatched
      • assert column name
      • assert valid expression in the notebook editor widget
  • Via column header drill in table visualization
    • is displayed only in columns created by aggregations
    • is not displayed for data columns
    • is not displayed for custom columns
    • is not displayed for breakout columns
      • 1 aggregation
        • no breakout
        • breakout on binned datetime column
        • breakout on non-binned datetime column
        • breakout on non-datetime column
      • multiple aggregations
        • no breakout
        • breakout on binned datetime column
        • breakout on non-binned datetime column
        • breakout on non-datetime column
    • adds new column(s)
      • assert analytic event dispatched
      • assert column name
      • assert valid expression in the notebook editor widget
@kamilmielnik kamilmielnik self-assigned this Jun 4, 2024
@kamilmielnik kamilmielnik changed the title Test coverage Test plan Jun 4, 2024
@kamilmielnik kamilmielnik changed the title Test plan [Testing plan] Jun 4, 2024
@kamilmielnik kamilmielnik changed the title [Testing plan] [Testing plan] Time-over-time comparison Jun 4, 2024
@kamilmielnik kamilmielnik added this to the 0.51 milestone Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant