Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FieldValues does not check for cardinality (cannot select value not listed) #5323

Closed
moumny opened this issue Jun 13, 2017 · 5 comments
Closed
Labels
Administration/Metadata & Sync Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Type:Bug Product defects

Comments

@moumny
Copy link

moumny commented Jun 13, 2017

In dashboards with category widget, the field/id/values call fills the database with 300values regardless of the cardinality of the column (cardinality is only checked in analysis).

This make the column unusable since you cannot enter a different value from the top 300.

Steps to reproduce

  1. Open data model of sample dataset
  2. Change the userID column in Orders to category
  3. New question -> sample dataset -> save question(raw data is fine) -> add to dashboard
  4. add categoryWidget in dashbord and bind to the userID of the the previous question
  5. Save and refresh the page
  6. You can now see you have a dropdown of userIDs (300 of them) even if there are 1700
@mazameli
Copy link
Contributor

Related to, or perhaps the same issue as this one I think: #5150

@moumny
Copy link
Author

moumny commented Jun 13, 2017

Oh yeah, correct, I did even comment on those...
I think it's quite a serious bug, might be worth 0.24.3 with a patch disabling the feature in the meantime. WDYT?

@salsakran salsakran added Type:Bug Product defects Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Administration/Metadata & Sync labels Jun 15, 2017
@camsaul
Copy link
Member

camsaul commented Aug 3, 2017

This was resolved by #5510. FieldValues won't get saved if cardinality is over the limit regardless of how it is triggered (old code only checked cardinality during sync but not if you manually set a category)

@camsaul camsaul closed this as completed Aug 3, 2017
@camsaul camsaul self-assigned this Aug 3, 2017
@camsaul camsaul added this to the 0.25.2 milestone Aug 3, 2017
@salsakran salsakran reopened this Aug 3, 2017
@camsaul camsaul removed their assignment Aug 3, 2017
@camsaul camsaul modified the milestone: 0.25.2 Aug 3, 2017
@camsaul camsaul changed the title field/values does not check for cardinality field/values does not check for cardinality (cannot select value not listed) Aug 30, 2017
@camsaul camsaul changed the title field/values does not check for cardinality (cannot select value not listed) FieldValues does not check for cardinality (cannot select value not listed) Aug 30, 2017
@mazameli
Copy link
Contributor

@salsakran you reopened this one a while back after the fix was implemented. Would you like to keep it open or can we call this resolved?

@mazameli
Copy link
Contributor

mazameli commented Nov 3, 2017

We haven't heard any users reporting that this problem has persisted since #5510 was merged. I motion that we close this issue.

@mazameli mazameli closed this as completed Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Administration/Metadata & Sync Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Type:Bug Product defects
Projects
None yet
Development

No branches or pull requests

4 participants