We shouldn't leak stack traces in the event of an error downloading a csv

[agilliland]

We should show the same sort of error we do elsewhere in the site, rather than just an unstyled stack trace.

[agilliland]

attachment

[camsaul]

So maybe we should expose the download CSV stuff in a different way? Since we're just hitting the API endpoint directly the stacktrace error response is normal behavior

[agilliland]

I'm cool with that. There is no specific reason it has to be part of the api.

That being said, I am generally of the opinion that an endpoint shouldn't be limited to just JSON responses. e.g. if someone just wants to run a QP query and get the result as a CSV I think it still makes sense to use /api/meta/dataset as the endpoint.

[camsaul]

Ya that's what I meant. Keep the API endpoint the same but add some UI to wrap it or something so we're not giving the user a link to it directly