Hitting enter doesn't save filter changes

[camsaul]

So I'm typing a new value for my Query Builder filter in and since my hands are already on the keyboard I hit enter thinking it will apply the values like it does everywhere else in the app where we use filters (for example Dashboard params). Instead it just closes the filter popover and does not apply any changes at all.

In fact since you must hit enter to apply other filters IMO this is confusing behavior 101.

⬇️ Please click the 👍 reaction instead of leaving a +1 or 👍 comment

[mazameli]

I could have sworn I'd filed an issue for this already, but in any case I agree a million times yes to this. Enter should absolutely commit the changes.

[camsaul]

This is related to #2059 I think

[flamber]

It seems to be only an issue for date pickers. When trying number/string picker, then it saves on Enter.
On the date picker, if you try to input 300 and press Tab and then Enter, then it works. OnBlur issue?

[ranquild]

Unassigning since the UI has changed and it's not clear what the correct behavior would be.

[uladzimirdev]

I believe that UI has been reworked and we don't have this issue anymore.

[nemanjaglumac]

I can still reproduce this on latest master d35c779.

1. Open any table from the Sample Database (let's use Analytic Events)
2. Click on a timestamp column
3. Choose "Filter by this column" from the dropdown
4. Choose "Last 30 days" (It should show no results)
   
5. Click on a filter "Timestamp Previous 30 Days" to edit it
   
6. Edit the number and click "enter" - nothing happens
   

Also not that it says "Add filter" and not "Update filter"

[WiNloSt]

Reproducible in https://github.com/metabase/metabase/pull/34851/commits (e546daa), even though the filter popover got updated immediately when the value is changed, it doesn't update the question filter, nor Enter update the question filter.

[ranquild]

Fixed by #35658