Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom map not view in shared Dashboards #6593

Closed
chenlingmin opened this issue Dec 19, 2017 · 5 comments
Closed

Custom map not view in shared Dashboards #6593

chenlingmin opened this issue Dec 19, 2017 · 5 comments
Labels
Priority:P2 Average run of the mill bug .Security related Type:Bug Product defects Visualization/

Comments

@chenlingmin
Copy link

Hello

I added custom Map, It's worked.
But not work in my shared Dashboard.

I found GET api/geojson/a5bc9fba-6bc6-4bbf-6304-87b9ad5d5493 api unauthenticated
image

@tewald
Copy link

tewald commented Dec 22, 2017

It's a permission issue.
The /geojson route is auth protected.
I've made it work by cloning the repository and changing the line:
(context "/geojson" [] (+auth geojson/routes))
to
(context "/geojson" [] geojson/routes)
on the metabase/api/routes.clj file.

@salsakran salsakran added .Security related Visualization/ Type:Bug Product defects Priority:P2 Average run of the mill bug labels Dec 29, 2017
@salsakran
Copy link
Contributor

Hmm. Are there any security implications to allowing custom geojson files to be downloaded from an instance without authing? Obviously, if you're using them in a public dashboard, you need to be able to get to them without authenticating, but we should probably only allow GETs and not other HTTP verbs.

@flamber
Copy link
Contributor

flamber commented Feb 23, 2019

This issue is most likely a duplicate of #5338, despite referencing embedded, since both issues are failing to get the map from the same end point /api/geojson/:UUID

@MarcGJA
Copy link

MarcGJA commented Apr 3, 2019

Metabase v0.31.2
AWS EBS
JWT embedding w/maps

So how can I go about implementing @tewald's solution on a working EBS Metabase instance?

The thought of editing clj code, learning how to use Docker (I haven't a clue), plus dealing with AWS's eccentricities (sans MySQL option #9021) is somewhat intimidating but I'm going to have to do something soon.

Embed custom geojson maps (totally under my control, I designed them from scratch) are a must-have even with "to-do" list items like binning miss-categorizations (#7486, #9208), floating maps with peek-a-boo labels (#7638), and single-color shading (#9682).

Something is better than nothing which is what we've got right now (#5338, #9193 closed as dup).

@camsaul
Copy link
Member

camsaul commented Apr 10, 2019

Duplicate of #5338

@camsaul camsaul marked this as a duplicate of #5338 Apr 10, 2019
@camsaul camsaul closed this as completed Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:P2 Average run of the mill bug .Security related Type:Bug Product defects Visualization/
Projects
None yet
Development

No branches or pull requests

6 participants