This regex can be stucked by strings

[2bdenny]

metabase/frontend/src/metabase/lib/expressions/parser.js

Line 359 in b155205

.replace(/(\n|\s)*but found:?/, " but found ")

Hello =), I try to extract all regexes in the project and test them, and find this one can be stucked by inputs. If the string, error.message contains too many \n, like "\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n", it will be stucked over 30 seconds.
Recommend /(\s)*but found:?/ instead.

[senior]

What version of Metabase were you testing this on? I created a test like the one below:

    it("can ignore whitespace", () => {
        let s = "A * \n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n +"
        expect(compile(s, expressionOpts)).toEqual(["field-id", 1]);
    });

And it failed (as expected) but there was no noticeable impact on performance.

[victoriaspek]

Closing - has been labeled as "needs more info" and "unable to reproduce" for over a year.