Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning gitbook-plugin-atoc@1.0.3: The engine "gitbook" appears to be invalid. #7558

Closed
ad-m opened this issue May 5, 2018 · 4 comments
Closed
Labels
Type:Tech Debt or Refactoring

Comments

@ad-m
Copy link

ad-m commented May 5, 2018

Bugs

If you're filing an issue about a bug please include as much information
as you can including the following.

  • Your browser and the version: not approciate

  • Your operating system: Ubuntu 16.04.4 LTS

  • Your databases: not approciate

  • Metabase version: 18bf85eb3f2642e7df9a198abd4d871af7176a05

  • Metabase hosting environment: Docker

  • Metabase internal database: not approciate

  • Repeatable steps to reproduce the issue

$ git clone https://github.com/metabase/metabase.git
...
$ cd metabase
$ docker build .
...
$ echo $npm_execpath | grep -q yarn || echo '\033[0;33mSorry, npm is not supported. Please use Yarn (https://yarnpkg.com/).\033[0m'
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
warning gitbook-plugin-atoc@1.0.3: The engine "gitbook" appears to be invalid.
info fsevents@1.1.3: The platform "linux" is incompatible with this module.
info "fsevents@1.1.3" is an optional dependency and failed compatibility check. Excluding it from installation.
[4/5] Linking dependencies...
warning " > postcss-cssnext@2.11.0" has unmet peer dependency "caniuse-db@^1.0.30000652".
[5/5] Building fresh packages...
Done in 105.58s.
Running 'webpack' with NODE_ENV=production assemble and minify frontend assets...
Node#before is deprecated. Use Node#raws.before
Hash: 64329f86ebc9f59a3a6f
Version: webpack 3.10.0
Time: 322690ms
...
@jornh
Copy link
Contributor

jornh commented May 5, 2018

This is probably just a harmless warning. Or are you running into build or translation problems due to this?

The dependency is brought into Metabase via the c-3po package.

The way to get rid of the warning would be to bump the c-3po dependency to v0.8.0 which has moved gitbook-plugin-atoc into being just a dev dependency (see ttag-org/ttag@fad940e#diff-b9cfc7f2cdf78a7f4b91a753d10865a2).

But while on the topic c-3po they apparently had to rename to ttag: ttag-org/ttag#105 .... I wonder why 😉 🤖... So this means that what started out as a simple version bump could as well end out in being a dependency/tooling rename including:

It’s probably not feasible to do until the remodeling dust has settled in ttag land. 🇨🇳 🇧🇷 🇪🇸 🇩🇪 🇫🇷 🇵🇱

@AlexMost
Copy link

AlexMost commented May 6, 2018

Hey, that dependency was accidentally placed in "dependencies" instead of "devDependencies" field in the package.json. Sorry for the troubles, version 0.8.0 fixes that.

The main reason why we are moving to the new name is that issue.

The migration process will require only installing ttag, babel-plugin-ttag and renaming all the occurrences of c-3po to ttag. We are also going to support the old c-3po@0.8.x version with bugfixes, so you can do that migration later.

Feel free to create issues with suggestions about how we can improve the translation workflow with ttag here.

@ad-m
Copy link
Author

ad-m commented May 6, 2018

I saw only a warning. I reported because the warning has its cause. Registering a warning as an issue is a step to eliminate the cause of the warning.

@flamber
Copy link
Contributor

flamber commented May 23, 2020

Fixed by #9733 since 0.32.9

@flamber flamber closed this as completed May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Tech Debt or Refactoring
Projects
None yet
Development

No branches or pull requests

5 participants