Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Presto instance to have SSL enabled #2

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Conversation

jeff303
Copy link

@jeff303 jeff303 commented May 24, 2021

(in addition to HTTP/insecure)

Adding versions of every catalog that have "-" replaced with "_" due to a bug
in the Presto JDBC driver (prestodb/presto#10739)

Exposing SSL port from Docker image

Adding convenient build script

…ecure)

Adding versions of every catalog that have "-" replaced with "-" due to a bug
in the Presto JDBC driver

Exposing SSL port from Docker image

Adding convenient build script
Copy link

@dpsutton dpsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff is annoying. It doesn't show that you renamed the files. Just that you added connector.name=memory to all of the files

@jeff303
Copy link
Author

jeff303 commented Jun 1, 2021

The diff is annoying. It doesn't show that you renamed the files. Just that you added connector.name=memory to all of the files

These are all new files (not renamed). Each one is a copy of an existing file that used dashes to separate the name parts. These new versions use underscores instead due to the aforementioned Presto JDBC driver bug.

The existing "dashed" versions are all still here, so that the existing driver/tests work the same (I wanted to minimize changes there, even though theoretically we could switch our testing code to do the same dash-to-underscore conversion that the JDBC driver testing code does).

@jeff303 jeff303 merged commit a6ced89 into master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants