Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the apply-type-fns issue #90

Merged
merged 2 commits into from
Jan 21, 2022

Conversation

marksto
Copy link
Contributor

@marksto marksto commented Dec 21, 2021

@camsaul Addresses the issue #70.

  • Ensure the PR follows the Clojure Style Guide and the Metabase Clojure Style Guide.
  • Tests and linters pass. You can run them locally as follows: lein test && lein lint
  • Make sure you've included new tests for any new features or bugfixes
  • New features are documented, or documentation is updated appropriately for any changed features.
  • Carefully review your own changes and revert any superfluous ones.
  • Include a detailed explanation of what changes you're making and why you've made them. [see the issue for details]

@marksto marksto changed the title Fix/apply type fns issues Fix the apply-type-fns issue Dec 21, 2021
@camsaul camsaul merged commit ae341d9 into metabase:master Jan 21, 2022
@pawit-metabase pawit-metabase linked an issue Mar 25, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apply-type-fns does not apply the function if the value is false
2 participants