Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deadlock when invoking hover/reference resolution in the Eclipse LWB #58

Closed
Gohla opened this issue Sep 17, 2021 · 1 comment
Closed
Labels
C-Bug Category: bug. Not working as expected P-High Priority: high. Should take priority over low and non-prioritized

Comments

@Gohla
Copy link
Member

Gohla commented Sep 17, 2021

Summary

A deadlock can occur sometimes when invoking hover/reference resolution in the Eclipse LWB.

What you did

Build a language and then invoke hover/reference resolution.

What you expected to happen

No deadlock to occur.

What actually happened

A deadlock occurs.

Context

  • Spoofax version: 0.11.10
  • Operating system & version: Any

Additional information

Thread dump: https://gist.github.com/Gohla/661524b25904b5010f3ddd98525a2057
The dump indicates that both the:

  • Main thread (which is invoking hover) is waiting on a lock because it walks the project resources (due to executing the Sdf3GetSourceFiles task), and this lock is probably locked because the Spoofax LWB builder thread holds a lock on the entire project.
  • Spoofax LWB builder thread probably locks the entire project, but is stuck waiting on a lock for writing to the console.

It is unclear to me why the builder thread is stuck waiting on the console.

@Gohla Gohla added C-Bug Category: bug. Not working as expected P-High Priority: high. Should take priority over low and non-prioritized labels Sep 17, 2021
@Gohla
Copy link
Member Author

Gohla commented Sep 20, 2021

Fixed by 04b6515, to be released in 0.11.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Bug Category: bug. Not working as expected P-High Priority: high. Should take priority over low and non-prioritized
Projects
None yet
Development

No branches or pull requests

1 participant