Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commands that fail give no feedback in the Eclipse LWB #68

Closed
Gohla opened this issue Sep 29, 2021 · 1 comment
Closed

Commands that fail give no feedback in the Eclipse LWB #68

Gohla opened this issue Sep 29, 2021 · 1 comment
Labels
C-Bug Category: bug. Not working as expected P-High Priority: high. Should take priority over low and non-prioritized

Comments

@Gohla
Copy link
Member

Gohla commented Sep 29, 2021

Summary

Commands that fail give no feedback. For example, running the "Show parsed AST" on a file that does not parse gives no feedback.

What you did

Run a command that fails.

What you expected to happen

Feedback in the form of an error pop-up to appear.

What actually happened

No feedback appears.

Context

  • Spoofax version: 0.12.1
  • Operating system & version: Any

Additional information

This used to work, but probably happened due to now running commands in Eclipse jobs? I also changed how errors are handled, which may have caused it.
@Gohla Gohla added C-Bug Category: bug. Not working as expected P-High Priority: high. Should take priority over low and non-prioritized labels Sep 29, 2021
Gohla added a commit that referenced this issue Oct 1, 2021
@Gohla
Fix commands that fail give no feedback in the Eclipse LWB (#68)
b690027
@Gohla
Copy link
Member Author

Gohla commented Oct 1, 2021

Fixed by b690027

@Gohla Gohla closed this as completed Oct 1, 2021
Virtlink pushed a commit that referenced this issue Oct 4, 2021
@Gohla @Virtlink
Fix commands that fail give no feedback in the Eclipse LWB (#68)
91491c8
Virtlink pushed a commit that referenced this issue Oct 6, 2021
@Gohla @Virtlink
Fix commands that fail give no feedback in the Eclipse LWB (#68)
362d9d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Bug Category: bug. Not working as expected P-High Priority: high. Should take priority over low and non-prioritized
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Gohla