Tego runtime #73
Merged
Tego runtime #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gohla
reviewed
Oct 5, 2021
There was a problem hiding this comment.
Looks good! I did not do an in-depth review of the Tego runtime, but focused on the integration and API. I left a couple of in-line comments and some main comments here:
- Should the runtime project just be called
tego? I assume there is a Tego meta-language as well? If so, I think the meta-language should be calledtegoand the Tego runtime should be calledtego.runtimeor something like that. - You mimic the Stratego runtime classes which require a lot of weird state and hacks to get working correctly. For example, does the Tego runtime require the language definition directory as input? And do we need to create a new Tego runtime every time? It would be good to think a bit about the API here and design a clean Tego runtime. Preferably it should be created once, with all state being passed into an invocation of the runtime.
These are also issues that we can solve later if you do not have time to work on that right now. We can merge and make an enhancement issue which should be resolved in the future.
.../resources/mb/spoofax/compiler/language/tego_runtime/TegoRuntimeBuilderFactory.java.mustache
Outdated
Show resolved
Hide resolved
...aces/src/main/java/mb/spoofax/compiler/interfaces/spoofaxcore/TegoRuntimeBuilderFactory.java
Outdated
Show resolved
Hide resolved
...compiler/src/main/resources/mb/spoofax/compiler/adapter/adapter_project/Module.java.mustache
Outdated
Show resolved
Hide resolved
Virtlink
force-pushed
the
tego-runtime
branch
from
f96ede3
to
7bf96a7
Compare
|
I renamed the project to The PR is again ready for review. |
Gohla
requested changes
Oct 20, 2021
core/spoofax.compiler/src/main/java/mb/spoofax/compiler/util/Shared.java
Outdated
Show resolved
Hide resolved
...compiler/src/main/resources/mb/spoofax/compiler/adapter/adapter_project/Module.java.mustache
Outdated
Show resolved
Hide resolved
core/spoofax.compiler/src/main/java/mb/spoofax/compiler/adapter/TegoRuntimeAdapterCompiler.java
Show resolved
Hide resolved
core/tego.runtime/src/main/java/mb/tego/strategies/TegoComponent.java
Outdated
Show resolved
Hide resolved
...ler/src/main/resources/mb/spoofax/compiler/platform/intellij_project/Component.java.mustache
Outdated
Show resolved
Hide resolved
Gohla
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Tego projects, language, and runtime, and the Tego compilers, mustache templates, and CFG option. Tego is the name of the lazy strategy language for Statix solver states and code completion.