Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spoofax/928: allows users to choose their own JVM options. #10

Merged
merged 6 commits into from Nov 27, 2014

Conversation

ghost
Copy link

@ghost ghost commented Nov 24, 2014

This pull requests allows users to choose their own JVM options:

  • ESV support, e.g.: jvm opts: -server -Xss8m -Xmx1024m (Format: -X[ss|mx]<size>[g|G|m|M|k|K])
  • At runtime, it takes all the languages in the registry into account to calculate the highest Xss and the highest Xmx. If the highest Xss/Xmx is higher than the current Xss/Xmx, a configuration warning is generated.
  • If a plugin specifies no JVM options, then the default options for Spoofax are used (-server -Xss8m -Xmx1024m)
  • If there is only one language in the registry, the configuration warning is now named YourLang configuration warning instead of Spoofax configuration warning.

Note: Only -server, Xss and Xmx JVM options are currently supported.

@Gohla
Copy link
Member

Gohla commented Nov 25, 2014

  1. Are you sure that all languages are registered before checkJVMOptions is called?
  2. Did you test this by doing a full build of Spoofax using the spoofax-releng repository?

@ghost
Copy link
Author

ghost commented Nov 25, 2014

  1. Yes, I looked at IMP's code LanguageRegistry.getLanguages() actually makes sure that the LanguageRegistry is initialized. It even works for dynamically loaded languages, which means that you can test the feature by building the project and restarting Eclipse.
  2. Yes.

Gohla added a commit that referenced this pull request Nov 27, 2014
Spoofax/928: allows users to choose their own JVM options.
@Gohla Gohla merged commit 2ab5693 into master Nov 27, 2014
@Gohla
Copy link
Member

Gohla commented Nov 27, 2014

Thanks!

@ghost ghost deleted the Spoofax/928 branch December 3, 2014 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants