Event art archive support #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mwiencek
commented
Dec 14, 2020
•
mwiencek
commented
- Add API support for events, and for fetching an eventartarchive.org index page
- Upgrade Python to 3.11
- Upgrade SQLAlchemy to v2
- Remove Bootstrap
This project will also serve event art in the future.
Fixes line wrapping and some grammar.
that this was missing from the h1 on the homepage disturbs me greatly
This seems to be required by the new musicbrainz-test-database images I switched over to in 8eb69cd.
I don't see any good reason to use Bootstrap (pulling in hundreds of kilobytes of JS/CSS) just to display a single static page that links to documentation. I've kept the display of the page nearly identical. The only real feature of BS we used was the navbar collapse. It no longer collapses (and doesn't need to, as there are only three items), but does re-orient itself below the main logo. This reduces the project complexity significantly (dropping dependencies on Bootstrap and less, both of which were severly out of date, plus node and npm), and reduces the unminified page size from ~243 KB to ~71 KB.
reosarevok
reviewed
Oct 26, 2023
| def resolve_event_art(self, mbid, type, thumbnail): | ||
| """Get the frontiest artwork image.""" | ||
|
|
||
| if type == "Front": |
There was a problem hiding this comment.
Wait, so events have a "front"?
There was a problem hiding this comment.
Yeah, it's just the "most representative" image for the event, but the terminology was kept the same for simplicity (I think the IA had asked about it, since they use the "front" flag to determine what image to show on their details page).
Right now it's shamelessly copied from the Cover Art Archive, minus the logos which don't exist yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.