Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(edition): Allow Edition Groups to be auto-created if editing an existing Edition #243

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

MonkeyDo
Copy link
Contributor

@MonkeyDo MonkeyDo commented Oct 8, 2020

Previously, an EG would be created automatically if a new Edition was created without an EG selected.
This PRs adds the possibility for an existing Edition edit to remove the previously selected EG and auto create a new one.

See metabrainz/bookbrainz-site#522 and https://tickets.metabrainz.org/browse/BB-537 for context

If an Edition doesn't have an EG filled (whether it be during creation or edit, previously only for cretion), auto create an EG.
See metabrainz/bookbrainz-site#522 for context
@coveralls
Copy link

coveralls commented Oct 8, 2020

Coverage Status

Coverage increased (+0.04%) to 59.273% when pulling a65db6e on auto-create-eg-existing-edition into da4e85b on master.

@MonkeyDo MonkeyDo merged commit d1ebfae into master Oct 8, 2020
@MonkeyDo MonkeyDo deleted the auto-create-eg-existing-edition branch October 8, 2020 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants