Repeatable imports #314
Merged
Repeatable imports #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without them, the return type of `bookshelf.transaction()` is unusable. Alternatively we could make `@metabrainz/bookshelf` depend on them, but I don't want to put effort into that fork again.
Also drop a (harmless but redundant) duplicate conversion to snake case.
Only accepting a boolean flag to overwrite pending imports is no good long term solution because a future flag to update already accepted imports only makes sense if pending imports are also updated. To account for all the possible outcomes of an import, the function should return the import's status in addition to the ID. Not all possible values will be supported by the initial version.
This feature currently only updates the import metadata and points the import header to the freshly created data rows, but leaves the old data of previous import attempts behind orphaned.
Knex does not seem to implement `.upsert()` for postgres.
MonkeyDo
reviewed
Nov 7, 2023
MonkeyDo
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing imports can now be updated if they are still pending. The implementation currently only overwrites the import header to link to the freshly created entity data and leaves all the old entity data behind orphaned. (Still to be improved...)
I've also made the options parameter more flexible to already include support for creating updates for accepted entities as well (which might be added in a future version.) In addition to the import ID, the
createImportfunction now also returns its status (which is used by the consumer).Also contains a few more fixes for type errors (in currently unused code) which I somehow had not seen so far.