-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BB-445: Remove GSoC 2016 as achievement #418
Conversation
What's the point of doing this? Gsoc 2016 was when we added achievements and the person who wrote the code has the achievement, I think we should keep acknowledging them. :) Also, maybe there's an idea here to add achievements for the rest of the GSoC students? |
@paramsingh |
After some thought, I suggest changing the scope of the achievement to "Participated in GSOC" without a specific year. What do you think @chinmay-kothari and @paramsingh? |
that sounds great to me! |
@MonkeyDo , I have added GSoC as an achievement in general not year specific as you mentioned. Let me know how does it look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this would most likely work as expected, why not simply modify the fields in the existing badge?
I thought about that and used updating the row rather than deleting and adding. I did this few days back but forgot to commit :p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go !
Problem
Achievements section has GSoC 2016 as an achievement which didn't even have an image.
Solution
Deletes GSoC 2016 as an achievement from the database.
Areas of Impact
Database: sql/migration