Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB-445: Remove GSoC 2016 as achievement #418

Merged
merged 3 commits into from
Apr 27, 2020

Conversation

chinmay-kothari
Copy link
Contributor

Problem

Achievements section has GSoC 2016 as an achievement which didn't even have an image.

Solution

Deletes GSoC 2016 as an achievement from the database.

Areas of Impact

Database: sql/migration

@coveralls
Copy link

coveralls commented Apr 19, 2020

Coverage Status

Coverage increased (+0.5%) to 50.268% when pulling 1a915d4 on chinmay-kothari:gsoc_badge into b3c24ce on bookbrainz:master.

@paramsingh
Copy link
Collaborator

What's the point of doing this? Gsoc 2016 was when we added achievements and the person who wrote the code has the achievement, I think we should keep acknowledging them. :)

Also, maybe there's an idea here to add achievements for the rest of the GSoC students?

@chinmay-kothari
Copy link
Contributor Author

@paramsingh
Yeah true they actually not creating any problem or so. I liked your idea of rather adding GSoC as an achievement not just for 2016 but for rest of the people also. That would certainly make GSoC students much more happier XD.
What do you think about this @MonkeyDo ?

@MonkeyDo
Copy link
Contributor

After some thought, I suggest changing the scope of the achievement to "Participated in GSOC" without a specific year.
That way we both maintain the achievement and also extend it so that more than one single person is able to claim it.

What do you think @chinmay-kothari and @paramsingh?

@paramsingh
Copy link
Collaborator

that sounds great to me!

@chinmay-kothari
Copy link
Contributor Author

@MonkeyDo , I have added GSoC as an achievement in general not year specific as you mentioned. Let me know how does it look?

Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this would most likely work as expected, why not simply modify the fields in the existing badge?

@chinmay-kothari
Copy link
Contributor Author

While this would most likely work as expected, why not simply modify the fields in the existing badge?

I thought about that and used updating the row rather than deleting and adding. I did this few days back but forgot to commit :p

Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go !

@MonkeyDo MonkeyDo merged commit 7479380 into metabrainz:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants