Feature: Remove Collaboration #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonkeyDo
reviewed
Aug 11, 2020
There was a problem hiding this comment.
Another useful feature !
I wonder if instead of the button being below the list of entries, which might suggest that it's an action on the list items, we could show a really small button or just an icon next the the collaborator's name (next to my own name only), something like this:
What do you think?
src/client/components/pages/parts/delete-or-remove-collaboration-modal.js
Show resolved
Hide resolved
| You’re about to remove yourself as a collaborator of Collection: {collection.name}. | ||
| </h4> | ||
| <p> | ||
| Are you sure you want to do this ? You won’t be able to undo this. |
There was a problem hiding this comment.
Suggested change
| Are you sure you want to do this ? You won’t be able to undo this. | |
| Are you sure you want to proceed ? You won’t be able to undo this. |
src/client/components/pages/parts/delete-or-remove-collaboration-modal.js
Outdated
Show resolved
Hide resolved
MonkeyDo
requested changes
Aug 13, 2020
src/client/components/pages/parts/delete-or-remove-collaboration-modal.js
Outdated
Show resolved
Hide resolved
src/client/components/pages/parts/delete-or-remove-collaboration-modal.js
Show resolved
Hide resolved
src/client/components/pages/parts/delete-or-remove-collaboration-modal.js
Outdated
Show resolved
Hide resolved
|
Oops. I made so many silly mistakes in this PR. |
Everyone has tired days :) |
MonkeyDo
requested changes
Aug 27, 2020
src/client/components/pages/parts/delete-or-remove-collaboration-modal.js
Outdated
Show resolved
Hide resolved
src/client/components/pages/parts/delete-or-remove-collaboration-modal.js
Outdated
Show resolved
Hide resolved
src/client/components/pages/parts/delete-or-remove-collaboration-modal.js
Outdated
Show resolved
Hide resolved
src/client/components/pages/parts/delete-or-remove-collaboration-modal.js
Outdated
Show resolved
Hide resolved
MonkeyDo
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Collaborators should have an option to remove collaboration from a collection
Solution