Delete collection from Elasticsearch index

[prabalsingh24]

Problem

After deleting the collection from Database, it has to be deleted from ES index as well

[coveralls]

Coverage increased (+1.1%) to 59.182% when pulling d0d59a9 on prabalsingh24:delete-collection-from-ES into ef27871 on bookbrainz:UserCollection.

[MonkeyDo]

Hole in one !
Nice catch on remembering to remove from the index, and nice PR with nothing to change!

Well done ! 💯

For my own curiosity, could you explain why you changed a few instances of UserCollectionItem({collectionId: collection.get('id')}) into UserCollectionItem().where('collectionId', collection.get('id'))?
I saw the same in another PR, and I thought they were pretty much interchangeable (and now I'm thinking i've been missing something this whole time)

[prabalsingh24]

I've seen that sometimes UserCollection({id: 1}).fetchAll() gives incorrect result. whereas with fetch it works fine.

When i have to use fetch , I use UserCollection({id: 1}).fetch() whereas when i have to do fetchAll I use UserCollection().where('id', 1).fetchAll

[MonkeyDo]

Huh, interesting. I wonder why that is.
Thanks for the tip!

[prabalsingh24]

I could be wrong too. But i experienced it at many places.

[prabalsingh24]

Next time i see a similar issue, I'll check it properly. Will use debug true and see what happens