Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Prevent conflict in test fixtures ids #507

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Conversation

MonkeyDo
Copy link
Contributor

@MonkeyDo MonkeyDo commented Sep 1, 2020

Problem

Tests were failing erratically because of two reasons:

  1. We were assigning an id to pretty much all the test fixtures we created using the ORM, when it's not necessary
  2. The random number generator we were using to generate the ids was creating conflicting ids

Solution

Let the database create ids, which required a few changes in the test helpers.

Areas of Impact

Tests only.

@MonkeyDo
Copy link
Contributor Author

MonkeyDo commented Sep 1, 2020

@prabalsingh24 Requesting your eyes to double-check in case you spot something stupid :)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 62.721% when pulling bd77e6d on test-fixtures-ids into fae8612 on master.

@MonkeyDo MonkeyDo merged commit a450600 into master Sep 7, 2020
@MonkeyDo
Copy link
Contributor Author

MonkeyDo commented Sep 7, 2020

I'll merge this now, but you can still review and comment if you spot anything !

@MonkeyDo MonkeyDo deleted the test-fixtures-ids branch September 7, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants