Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pagination url for collection table #512

Merged
merged 2 commits into from
Sep 9, 2020

Conversation

prabalsingh24
Copy link
Contributor

Problem

Pagination is collection table was not working properly

Solution

fixed the pagination url. Removed an extra ?

@prabalsingh24
Copy link
Contributor Author

prabalsingh24 commented Sep 8, 2020

This incorrect pagination url was causing some error in the pagination. The url was becoming collection?q=?size=20.
Removing that extra ? will fix it.

@coveralls
Copy link

coveralls commented Sep 8, 2020

Coverage Status

Coverage remained the same at 60.995% when pulling d7cb597 on prabalsingh24:fix-collection-pagination into c60c531 on bookbrainz:master.

Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, good catch, I made those changes to the pagination mechanism on master, and forgot it would break the collections page!
Sorry and thanks for fixing it quick!

@MonkeyDo MonkeyDo merged commit e233463 into metabrainz:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants