Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hierarchy and help text for relationships #514

Merged
merged 6 commits into from
Sep 25, 2020
Merged

Conversation

MonkeyDo
Copy link
Contributor

@MonkeyDo MonkeyDo commented Sep 23, 2020

Deployed on test.bookbrainz.org for testing.

This PR adds a few new features to improve the relationship editor:

  1. hierarchy in relationships in the relationship editor:

Capture d’écran 2020-09-23 à 15 55 58

  1. help tooltips when hovering over a relationship, both in the rel editor and the entity pages:

Capture d’écran 2020-09-22 à 18 22 22

Capture d’écran 2020-09-23 à 16 48 35

  1. Help text under the relationship select, once a relationship has been selected

  2. Disambiguation is shown in relationship select (for entities with the same name)

  3. An "open in a new tab" button next to the entity select in the relationship editor

Capture d’écran 2020-09-24 à 15 14 58

…ship display and and helptext in relationship editor
…hy in select options

Sort rels according to the parent/chil hierarchy defined in the DB and indent with spaces to display levels
@coveralls
Copy link

coveralls commented Sep 23, 2020

Coverage Status

Coverage decreased (-0.1%) to 60.878% when pulling bf782e4 on relationships-dropdown into 939b54f on master.

In the relationship editor. It will allow to differentiate between   entities with the same name
In relationship editor.
+ minor refactor (sortedArray->sortedRelationships)
@MonkeyDo MonkeyDo merged commit 4faf6cc into master Sep 25, 2020
@MonkeyDo MonkeyDo deleted the relationships-dropdown branch September 25, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants