Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name deduplication improvements #522

Merged
merged 8 commits into from
Oct 9, 2020
Merged

Name deduplication improvements #522

merged 8 commits into from
Oct 9, 2020

Commits on Oct 7, 2020

  1. fix(BB-356): Allow adding an edition or adition group with existing name 

    Don't deduplicate Editions and Edition Groups for now, until we have a better way to compare (author for EG, edition date, published, etc. for Edition)
    @MonkeyDo
    MonkeyDo committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    8ab6309 View commit details
    Browse the repository at this point in the history

  2. fix(BB-356): Correction for edition group deduplication 

    Allow to search for existing edition groups for new editions
    @MonkeyDo
    MonkeyDo committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    5f3ef3e View commit details
    Browse the repository at this point in the history

  3. Fix(BB-537): Don't auto-select matching Edition Group 

    Instead display possible options and also allow to search or auto-create.
If an EG is selected, hide the matching EGs component
    @MonkeyDo
    MonkeyDo committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    3b6973b View commit details
    Browse the repository at this point in the history

  4. fix(BB-413): Ignore current existing entity in autocomplete and dedup… 

    …lication

If I'm editing an existing entity, remove said entity from the alias-related search results (autocomplete and deduplication [disambiguation requirement])
    @MonkeyDo
    MonkeyDo committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    58ae8a9 View commit details
    Browse the repository at this point in the history

  5. fix(BB-537): Allow empty EditionGroup even if found a matching name 

    Allow for an EG to be created automatically even though there is an EG with the same name as the Edition, essentially creating a possibly duplicate EG.
    @MonkeyDo
    MonkeyDo committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    4da9841 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2020

  1. feat(BB-537): Allow empty (auto-create) EG for existing Edition

    @MonkeyDo
    MonkeyDo committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    58301c9 View commit details
    Browse the repository at this point in the history

  2. feat(edition-section): Tweaks to EditionGroup selection UI

    @MonkeyDo
    MonkeyDo committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    0f30b5c View commit details
    Browse the repository at this point in the history

  3. fix(BB-537): Fix issue with EditionGroup matching mechanism 

    Made checkIfNameExists an async function instead of promise-based for clarity.
    @MonkeyDo
    MonkeyDo committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    1831eeb View commit details
    Browse the repository at this point in the history