Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(display): url discrepancy in entities and entity-editor name-section #551

Merged
merged 2 commits into from
Feb 2, 2021

Conversation

the-good-boy
Copy link
Contributor

Problem

Fixed the url discrepancy in entities (earlier it used to appear as 'W+ork' instead of 'work' in url).
Also there was a possible discrepancy in name-section url where kebab-casing was missing

Solution

A pretty straight-forward fix for the first case and a lodash kebabCasing in the second case

Areas of Impact

Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small correction and we're good to go :)

For your reference, once a pull request is open, you can still push commits to it.
So you don't have to close the PR and open another one if you've got modifications.

src/client/entity-editor/name-section/name-section.js Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.922% when pulling 0247dd6 on the-good-boy:myBranch2 into d17422d on bookbrainz:master.

Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!
Thanks a lot for opening a PR and fixing this issue !

@MonkeyDo MonkeyDo merged commit 64d335c into metabrainz:master Feb 2, 2021
@welcome
Copy link

welcome bot commented Feb 2, 2021

Congratulations on your first merged pull request for BookBrainz! 🎉
We're very thankful for your work, and happy to count you part of our team !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants