Fix (BB-589): Footer buttons get compressed and the text can't be read #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endurance21
reviewed
Mar 13, 2021
endurance21
reviewed
Mar 13, 2021
MonkeyDo
reviewed
Mar 16, 2021
There was a problem hiding this comment.
At a glance looking at your screen captures (thanks for that!) the solution looks great !
Unfortunately like PR #559 I can't review this properly as there are so many changes due to auto-formatting.
You can follow the instructions I left on the other PR to revert the changes and reapply just your intentional changes.
Thanks !
|
@MonkeyDo i have made the changes, thank you for the review :) |
MonkeyDo
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR Fixes: BB-589
Solution
Fixed the design issue by adding some custom
CSSand removing react bootstrap<ButtonGroup />ComponentBefore
bandicam.2021-03-13.09-33-17-335.mp4
After
bandicam.2021-03-13.09-33-48-591.mp4