Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX(BB-590): Display Publisher Achievement Badges #574

Merged
merged 1 commit into from
Mar 16, 2021
Merged

FIX(BB-590): Display Publisher Achievement Badges #574

merged 1 commit into from
Mar 16, 2021

Conversation

akashgp09
Copy link
Contributor

Signed-off-by: Akash Gupta akashgp9@gmail.com

Problem

This PR Fixes: BB-590

Publisher achievement badges are not displayed

Screenshot 2021-03-16 191814

Solution

Fixed the image path in the SQL INSERT INTO STATEMENT

Screenshot 2021-03-16 191904

Areas of Impact

create_type_data

@akashgp09
fix: incorrect image path in SQL statement
99f2b1b 
Signed-off-by: Akash Gupta <akashgp9@gmail.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.922% when pulling 99f2b1b on akashgp09:image-path into 4f5e5fd on bookbrainz:master.

MonkeyDo
MonkeyDo approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another good fix, thank you ! 🚀

I'll run a script to modify the production and test databases accordingly.

@MonkeyDo MonkeyDo merged commit 22aea13 into metabrainz:master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonkeyDo MonkeyDo MonkeyDo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@akashgp09 @coveralls @MonkeyDo