Feat (Core | BB-333) Implement a RelationshipType enum #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented Relationship_Type Enum as per the database (17-03-2021). Names in these enum are generated using columns in the 'relationship_type' table as - source_entity_type + link_phrase + target_entity_type. But some modifications are made wherever necessary.
|
As per the bookbrainz database (17-03-2021), I exported the relationship_type table in the following file - There are 69 rows in total so created 69 realtionship_types by using format - |
MonkeyDo
requested changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
BB-333
Implement Relationship_Type Enum as per the database (17-03-2021).
Solution
Names in these enum are generated using columns in the 'relationship_type' table as -
source_entity_type + link_phrase + target_entity_type.
But some modifications are made wherever necessary.
Areas of Impact
Added more type perspective for the codebase wherever relationship_type is used.