Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removed trailing space in getEntityLabel (BB-601) #586

Merged
merged 1 commit into from
Apr 6, 2021
Merged

fix: Removed trailing space in getEntityLabel (BB-601) #586

merged 1 commit into from
Apr 6, 2021

Conversation

BharatKalluri
Copy link
Contributor

Problem

Remove trailing space so that selections will not contain a space at the end

Solution

Currently getLabelEntity adds a space at the end. Looks like Label is always followed by disambiguation and getEntityDisambiguation already prefixes a space. So this should not be a problem :)

Areas of Impact

Text selection in title will be easier

@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.935% when pulling b51af41 on BharatKalluri:fix/remove_trailing_space_get_entity into c908c21 on bookbrainz:master.

Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look in the codebase, and it looks like indeed this trailing space can be removed without ill effects, and fixes the tickets.
Thanks !

@MonkeyDo MonkeyDo merged commit c56a0c5 into metabrainz:master Apr 6, 2021
@BharatKalluri BharatKalluri deleted the fix/remove_trailing_space_get_entity branch April 6, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants