Refactor(achievement): Rewritten Achievements helpers with async/await syntax #587
Conversation
Signed-off-by: Akash Gupta <akashgp9@gmail.com>
Signed-off-by: Akash Gupta <akashgp9@gmail.com>
Signed-off-by: Akash Gupta <akashgp9@gmail.com>
akashgp09
changed the title
Signed-off-by: Akash Gupta <akashgp9@gmail.com>
src/server/helpers/achievement.js
Outdated
| const unlock = await new UnlockType(awardAttribs).save(null, {method: 'insert'}); | ||
| return unlock.toJSON(); | ||
| } | ||
| return new Promise((resolve) => resolve('Already unlocked')); |
There was a problem hiding this comment.
This syntax is redundant, along with the same in the catch block.
Th async keyword already defines that the function returns a Promise, so instead of return new Promise([…] resolve(myReturnValue) you can simply return myReturnValue.
On the other side in the catch block you can simply throw err.
I'm not exactly sure why this code either returns an unlock object or the string 'Already unlocked', that seems a bit odd to me, but it's clear from the docs above that it's intended, so not an issue for now.
There was a problem hiding this comment.
On the other side in the catch block you can simply throw err
I have removed the try catch statement as the catch clause was only rethrowing the original error, which is redundant.
Co-authored-by: Monkey Do <MonkeyDo@users.noreply.github.com>
Co-authored-by: Monkey Do <MonkeyDo@users.noreply.github.com>
Co-authored-by: Monkey Do <MonkeyDo@users.noreply.github.com>
Co-authored-by: Monkey Do <MonkeyDo@users.noreply.github.com>
|
@MonkeyDo thank you so much for the detailed review 💯 . I have refactored the code as suggested, do let me know if changes are needed :) |
Problem
This PR Fixes: BB-598
Solution
A lot of the code uses promises in the
promise.then(…)format, which makes the code hard to read and maintain. Rewritten it using the async/await syntaxAreas of Impact
file src/server/helpers/achievement.js