Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete search limit #590

Merged
merged 5 commits into from
Apr 19, 2021

Conversation

nynaalekhya
Copy link
Contributor

@nynaalekhya nynaalekhya commented Apr 1, 2021

Closes BB-577

Problem

Search autocomplete endpoint responses are limited to 10 results

Solution

Changed the search autocomplete endpoint limit by including size property in dslQuery object body

Areas of Impact

src/common/helpers/search.js

@welcome
Copy link

welcome bot commented Apr 1, 2021

Thanks for opening your first pull request for BookBrainz, and welcome to our community! 🎉

If you haven't yet, please check out our contributing guidelines.

Someone will be reviewing your PR soon; just hang in there !
In the meantime, if you're wondering what to do next, you can have a look at our issue tracker

@coveralls
Copy link

coveralls commented Apr 1, 2021

Coverage Status

Coverage decreased (-0.009%) to 60.927% when pulling 84c9063 on nynaalekhya:autocomplete-search-limit into c908c21 on bookbrainz:master.

Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

@MonkeyDo MonkeyDo merged commit dee7a64 into metabrainz:master Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants