Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes badges visibility in editor's achievements tab #591

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

nynaalekhya
Copy link
Contributor

@nynaalekhya nynaalekhya commented Apr 1, 2021

Closes BB-605

Problem

Unlocked and Locked achievements are not visible on small screen devices
achievements

Solution

fixes badges visibility in editor's achievements tab
badge

Areas of Impact

src/client/stylesheets/style.less

@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.935% when pulling e5d9343 on nynaalekhya:badges-fix into c908c21 on bookbrainz:master.

@nynaalekhya nynaalekhya changed the title fixes badges visibilty in editor's achievements tab fixes badges visibility in editor's achievements tab Apr 1, 2021
Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple change that makes the page usable, which is a lot better than before :)
Thank you !

Longer term, we'll probably want to redesign that page a bit, as even with this improvement it's not very usable on mobile devices.

@MonkeyDo MonkeyDo merged commit 144a4b7 into metabrainz:master Apr 6, 2021
@nynaalekhya
Copy link
Contributor Author

@MonkeyDo Thank you, I would be glad to help you with the redesign.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants