Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added my collections button #592

Merged
merged 7 commits into from
Apr 7, 2021
Merged

Conversation

nynaalekhya
Copy link
Contributor

@nynaalekhya nynaalekhya commented Apr 1, 2021

Closes BB-596

Problem

Added My collections button

Solution

Public collections page
mycollection1

Viewing other collections
mycollection2

Clicking on my collections
collection3

Areas of Impact

@coveralls
Copy link

coveralls commented Apr 1, 2021

Coverage Status

Coverage decreased (-0.04%) to 60.9% when pulling e7e0065 on nynaalekhya:my-collections into c908c21 on bookbrainz:master.

Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition, that looks good !
A tiny little change and we can merge the PR.

href={`/editor/${user.id}/collections`}
type="button"
>
 My Collections
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
 My Collections
My Collections

Since there's no icon before the text we don't need that space

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the suggested changes.

Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this good addition !

@MonkeyDo MonkeyDo merged commit 8a3c5d8 into metabrainz:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants