Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX(editor): Update username in navbar after update in editor profile #598

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

akashgp09
Copy link
Contributor

@akashgp09 akashgp09 commented Apr 6, 2021

Signed-off-by: Akash Gupta akashgp9@gmail.com

Problem

This PR Fixes: BB-468

Solution

Now the name in the navbar is updated whenever we edit our name in editor profile.

simplescreenrecorder-2021-04-06_21.53.29.mp4

Areas of Impact

server/routes/editor.js

Signed-off-by: Akash Gupta <akashgp9@gmail.com>
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 60.927% when pulling 1ffac8f on akashgp09:update-username into 144a4b7 on bookbrainz:master.

Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks !

@MonkeyDo MonkeyDo merged commit 735b3cb into metabrainz:master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants